nolan/go-router
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix messed up default 404.

Browse Source
This commit is contained in:
nolwn
2020-12-15 00:38:09 -08:00
parent 05f90673c5
commit 19d616162f
2 changed files with 12 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
router_test.go
View File

@ -199,19 +199,14 @@ func testCustomNotFound(router Router, t *testing.T) {
expectedBody := "Forbidden"
expectedCode := 401
path := "/actual/path"
router.AddRoute(http.MethodPatch, path, func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(404)
w.Write([]byte("Not found."))
})
path := "/gibberish/forbidden"
router.NotFoundHandler = http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(expectedCode)
w.Write([]byte(expectedBody))
})
err := matchAndCheckRoute(&router, http.MethodPatch, "/gibberish/forbidden", expectedBody, expectedCode)
err := matchAndCheckRoute(&router, http.MethodPatch, path, expectedBody, expectedCode)
if err != nil {
t.Error("Did not call the custom handler.", err)
@ -227,12 +222,7 @@ func testDefaultNotFound(router Router, t *testing.T) {
expectedCode := 404
path := "/gibberish"
router.AddRoute(http.MethodDelete, path, func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(expectedCode)
w.Write([]byte(expectedBody))
})
err := matchAndCheckRoute(&router, http.MethodDelete, "/gibberish", expectedBody, expectedCode)
err := matchAndCheckRoute(&router, http.MethodDelete, path, expectedBody, expectedCode)
if err != nil {
t.Error("Did not find the expected callback handler", err)