Setup ServeHTTP on router.
This commit is contained in:
@ -154,7 +154,16 @@ func (r *Router) Get(path string, callback http.HandlerFunc) {
|
||||
r.AddRoute(http.MethodGet, path, callback)
|
||||
}
|
||||
|
||||
// ServeHTTP is the function that is required by http.Handler. It takes an http.ResponseWriter which
|
||||
// it uses to write to a response object that will construct a response for the user. It also takes
|
||||
// an *http.Request which describes the request the user has made.
|
||||
//
|
||||
// In the case of this router, all it needs to do is lookup the Handler that has been saved at a given
|
||||
// path and then call its ServeHTTP.
|
||||
func (r Router) ServeHTTP(w http.ResponseWriter, req *http.Request) {
|
||||
handler, _ := r.Handler(req)
|
||||
handler.ServeHTTP(w, req)
|
||||
|
||||
return
|
||||
}
|
||||
|
||||
|
@ -45,7 +45,7 @@ func TestAddRouter(t *testing.T) {
|
||||
// checkLookup(router.lookup)
|
||||
}
|
||||
|
||||
func TestHandler(t *testing.T) {
|
||||
func TestServeHTTP(t *testing.T) {
|
||||
router := Router{}
|
||||
path := "/items"
|
||||
expectedBody := "I am /items"
|
||||
@ -61,17 +61,6 @@ func TestHandler(t *testing.T) {
|
||||
if err != nil {
|
||||
t.Error("Did not find the expected callback handler", err)
|
||||
}
|
||||
|
||||
checkLookup(router.lookup)
|
||||
|
||||
}
|
||||
|
||||
func checkLookup(curr *segment) {
|
||||
fmt.Printf("%p { path: %s, methods: %v, children: %v}\n", curr, curr.path, curr.methods, curr.children)
|
||||
|
||||
for _, v := range curr.children {
|
||||
checkLookup(v)
|
||||
}
|
||||
}
|
||||
|
||||
func matchAndCheckRoute(r *Router, method string, path string, expectedBody string, expectedCode int) (err error) {
|
||||
@ -84,15 +73,7 @@ func matchAndCheckRoute(r *Router, method string, path string, expectedBody stri
|
||||
return
|
||||
}
|
||||
|
||||
h, pattern := r.Handler(request)
|
||||
|
||||
if pattern != "/items" {
|
||||
err = fmt.Errorf("The recovered patter does not match: %s", pattern)
|
||||
|
||||
return
|
||||
}
|
||||
|
||||
h.ServeHTTP(rr, request)
|
||||
r.ServeHTTP(rr, request)
|
||||
|
||||
if rr.Code != expectedCode {
|
||||
err = fmt.Errorf("The returned callback did not write 200 to the header. Found %d", rr.Code)
|
||||
@ -154,3 +135,12 @@ func addAndCheckRoute(r *Router, method string, path string, callback http.Handl
|
||||
|
||||
return
|
||||
}
|
||||
|
||||
// checkLookup prints out the various saved routes. It's not needed for any test, but is a helpful debugging tool.
|
||||
func checkLookup(curr *segment) {
|
||||
fmt.Printf("%p { path: %s, methods: %v, children: %v}\n", curr, curr.path, curr.methods, curr.children)
|
||||
|
||||
for _, v := range curr.children {
|
||||
checkLookup(v)
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user